Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API testdata for 1.19.0 #94341

Merged
merged 2 commits into from
Aug 31, 2020
Merged

Update API testdata for 1.19.0 #94341

merged 2 commits into from
Aug 31, 2020

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Aug 31, 2020 •
edited

What type of PR is this?

/area test
/kind cleanup

What this PR does / why we need it:
Ensures round-trip compatibility with released 1.19 API types

Data copied from HEAD testdata at v1.19.0:

git checkout v1.19.0
cp -fr staging/src/k8s.io/api/testdata/{HEAD,v1.19.0}
git checkout -b 1.19-api-testdata master
git add .
git commit -m "Add 1.19.0 API testdata"

NONE

/sig architecture

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. area/test kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 31, 2020
@dims
Copy link
Member

dims commented Aug 31, 2020

/approve
/lgtm
/hold until the tests pass

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Member Author

liggitt commented Aug 31, 2020

/retest

@liggitt
Copy link
Member Author

liggitt commented Aug 31, 2020

#94349 flake

@liggitt
Copy link
Member Author

liggitt commented Aug 31, 2020

/hold cancel
/milestone v1.20

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Aug 31, 2020
@liggitt
Copy link
Member Author

liggitt commented Aug 31, 2020

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 31, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit a28a692 into kubernetes:master Aug 31, 2020
@liggitt liggitt deleted the 1.19-api-testdata branch September 2, 2020 19:55
@dims dims mentioned this pull request Jan 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@dims dims Awaiting requested review from dims

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liggitt @dims @k8s-ci-robot @fejta-bot